Re: [patch] use gnome-mount and small fixes for gnome-vfs

[David Zeuthen <david fubar dk>]

On Fri, 2006-01-27 at 19:03 -0600, Federico Mena Quintero wrote:
> On Sun, 2006-01-15 at 16:16 -0500, David Zeuthen wrote:
> 
> > Also, nautilus and the gnomevfs filechooser backend still needs fixing
> > as they don't honor the contract (we introduced it in 2.12 I think, see
> > libgnomevfs/gnome-vfs-volume-ops.c:mount_umount_thread() - search for
> > 'contract'). This is bad as gnome-mount now displays error dialogs on
> > it's own but both Nautilus and the file chooser shows an empty dialog.
> > Which looks bad. Btw, these issues have to be resolved even without this
> > patch being applied.
> 
> What is that contract?  

It was described here

 http://mail.gnome.org/archives/gnome-vfs-list/2005-June/msg00013.html

To sum it up, basically don't show dialogs if both error_message and
detailed_error_message are empty strings.

> Is this in the gnome-vfs API docs anywhere?  I'm
> pretty sure this is an ABI break, but I'll happily fix the file chooser
> if you fix the API docs :)

Sounds like a deal, I've attached a patch with the fix. OK to commit?

Cheers,
David

Index: ChangeLog
===================================================================
RCS file: /cvs/gnome/gnome-vfs/ChangeLog,v
retrieving revision 1.2354
diff -u -p -r1.2354 ChangeLog
--- ChangeLog	24 Jan 2006 12:43:57 -0000	1.2354
+++ ChangeLog	29 Jan 2006 02:35:45 -0000
@@ -1,3 +1,8 @@
+2006-01-28  David Zeuthen  <davidz redhat com>
+
+	* libgnomevfs/gnome-vfs-volume.h (GnomeVFSVolumeOpCallback): 
+	Clarify documentation. 
+
 2006-01-24  David Zeuthen  <davidz redhat com>
 
 	Eject fixes, based on initial patch from Alexander Larsson. 
Index: libgnomevfs/gnome-vfs-volume.h
===================================================================
RCS file: /cvs/gnome/gnome-vfs/libgnomevfs/gnome-vfs-volume.h,v
retrieving revision 1.8
diff -u -p -r1.8 gnome-vfs-volume.h
--- libgnomevfs/gnome-vfs-volume.h	14 Apr 2005 18:48:29 -0000	1.8
+++ libgnomevfs/gnome-vfs-volume.h	29 Jan 2006 02:35:46 -0000
@@ -82,6 +82,19 @@ struct _GnomeVFSVolumeClass {
 	GObjectClass parent_class;
 };
 
+/**
+ * GnomeVFSVolumeOpCallback: 
+ * @succeeded:
+ * @error:
+ * @detailed_error:
+ * @user_data:
+ *
+ * Note that if succeeded is FALSE and error, detailed_error are both
+ * empty strings the client is not supposed to display a dialog as an
+ * external mount/umount/eject helper will have done so.
+ *
+ * Since: 2.6
+ */
 typedef void (*GnomeVFSVolumeOpCallback) (gboolean succeeded,
 					  char *error,
 					  char *detailed_error,