Re: [PATCH] unalias MIME types in application cache

[Christian Neumair <chris gnome-de org>]

Am Dienstag, den 25.04.2006, 11:26 +0200 schrieb Alexander Larsson:
> On Thu, 2006-04-06 at 16:31 +0200, Christian Neumair wrote:
> > The attached patch should fix bug 314952 [1] by unaliasing MIME types
> > before inserting the associated applications into the cache.
> > 
> > [1] http://bugzilla.gnome.org/show_bug.cgi?id=314952
> > 
> 
> The xdg_mime_ calls needs to be protected by the gnome_vfs_mime_mutex
> lock. I noticed some other calls in that files that weren't protected
> and am fixing them now.
> 
> However, I don't think this is the right way to solve this bug. I think
> update-desktop-database should do the unaliasing. That way every app
> doesn't have to do this itself each time it loads the mimeinfo.cache
> file. Don't you think this would be better?

I don't think it is a good idea to put unaliasing code into
update-desktop-database, because it adds much complexity (mime type
caching, parsing etc..) We already do much unaliasing at runtime, and
clearly, we would either have to parse the XML files ourselves, or - if
we read the alias cache - depend on a previous update-mime-database run,
which would make the currently orthogonal concept with a completely
separate cache only containing the .desktop file information less simple
and traceable. Shouldn't the association of these two caches be the
client's job?

-- 
Christian Neumair <chris gnome-de org>