Re: patch nag: refcount neon module

[Christian Neumair <chris gnome-de org>]

Am Freitag, den 15.09.2006, 10:53 +0200 schrieb Alexander Larsson:
> On Fri, 2006-09-15 at 10:46 +0200, Alexander Larsson wrote:
> > On Thu, 2006-09-14 at 21:48 +0200, Christian Neumair wrote:
> > > Handling multiple methods in one module requires refcounting, which
> > > currently isn't implemented properly for the neon method.
> > > http://bugzilla.gnome.org/show_bug.cgi?id=347470 provides a patch.
> > 
> > Looks good. Please commit.
> 
> Actually, this would be needed for other methods with aliases, like sftp
> (also known as ssh) and gzip (also gunzip).

Hrm the gzip/gunzip doesn't do anything in init/shutdown ATM, for sftp
this could indeed be useful, but the connection hash table is declared
never destroyed, and usually all methods/modules are shut-down at once.


> Maybe we should instead
> track the methods loaded by module name instead of method name? That way
> it would automatically work. (And we won't be opening a GModule twice.)

I think changing the way modules are initialized/shutdown is not really
an option at this stage of platform maturity. Yeah, this particular bit
of the API might not have been used very often, but maybe some modules
out there rely on being initialized for all their methods, possibly for
initializing extra libraries on the fly.

-- 
Christian Neumair <chris gnome-de org>