Re: l10n/i18n issue in gvfs

[Luca Ferretti <elle uca libero it>]

Il giorno dom, 23/12/2007 alle 09.53 +0100, Alexander Larsson ha
scritto:
> On Sat, 2007-12-22 at 22:12 +0100, Luca Ferretti wrote:
> > Il giorno sab, 22/12/2007 alle 21.06 +0100, Alexander Larsson ha
> > scritto:
> > > On Sat, 2007-12-22 at 12:34 +0100, Luca Ferretti wrote:
> > > > Il giorno sab, 22/12/2007 alle 12.08 +0100, Luca Ferretti ha scritto:
> > > > > Il giorno mer, 19/12/2007 alle 09.58 +0100, Alexander Larsson ha
> > > > > scritto:
> > > > > > On Tue, 2007-12-18 at 16:53 +0100, Luca Ferretti wrote:
> > > > 
> > > > > Note that the second one is missing a \ (xc2 instead \xc2)

This seems still unfixed. Patch attached

> > > > > I'm going to implement solution B
> > > > 
> > > > Here is the patch to use intltool framework. po/Makefile.in.in should be
> > > > removed from svn.
> > > 
> > > Is this needed now? I made some changes in HEAD that should put
> > > --from-code=UTF-8 in the gettext call
> > > 
> > 
> > Ehmm... did you forgot to commit?  ;-)
> 
> No, but the change was in po/Makefile.in.in which changed from
> autogenerated by autogen.sh to being checked in to svn. Maybe you didn't
> get the latest version of it checked out?
> 

On a fresh svn checkout it works, the previous error message is
disappeared, but now I can't install due to missing gvfs/mkinstalldirs
file.

make[1]: Entering directory `/home/luca/svn/gnome2/gvfs/po'
if test -r ".././mkinstalldirs"; then \
          .././mkinstalldirs /opt/gnome2/share; \
        else \
          /bin/sh ../mkinstalldirs /opt/gnome2/share; \
        fi
/bin/sh: Can't open ../mkinstalldirs
make[1]: *** [install-data-yes] Error 2
make[1]: Leaving directory `/home/luca/svn/gnome2/gvfs/po'
make: *** [install-recursive] Error 1

Now that autogen.sh don't run glib-gettextize I suppose you have to add
this file to repository (and eventually to dist).

Index: hal/ghaldrive.c
===================================================================
--- hal/ghaldrive.c	(revisione 1066)
+++ hal/ghaldrive.c	(copia locale)
@@ -156,7 +156,7 @@
         second = _("DVD\xc2\xb1R");
       if (hal_device_get_property_bool (d, "storage.cdrom.dvdrw") &&
           hal_device_get_property_bool (d, "storage.cdrom.dvdplusrw"))
-        second = _("DVDxc2\xb1RW");
+        second = _("DVD\xc2\xb1RW");
       if (hal_device_get_property_bool (d, "storage.cdrom.hddvd"))
         second = _("HDDVD");
       if (hal_device_get_property_bool (d, "storage.cdrom.hddvdr"))