[GnomeMeeting-devel-list] Re: [GnomeMeeting-devel-list] Re:[GnomeMeeting-devel-list] Re: [GnomeMeeting-devel-list]possible PATCH for the V4L plugin, TESTING&FEEDBACK needed!

[Damien Sandras <dsandras seconix com>]

Le sam 13/09/2003 à 21:11, julien puydt laposte net a écrit :
> Arg! That code is ugly enough already... there are already
> tests to know if mmap works or not, etc...
> 

Unfortunately, it is not the code's fault, but due to the video4linux
API.

> /me thinks the whole plugin would need to be rewritten
> (one thing prevents me to do this: v4l2 is supposed to appear
> some day near)
> 

Indeed, it is alreayd supported by some drivers.

> Snark
> 
> PS: in case you want to know how I would write it better:
> (...)PVideoDevice::GetFrameDataNoDelay(...)
> {
>   if(we_have_mmap && only_single_buffer)
>     return GetFrameDataNoDelayMmapSingleBuffer(...);
>   ...
> }
> that would make the various code path really separate, and
> make it easier to write/debug/share as much code as possible
> between them to avoid bugs.

That is indeed the kind of things I had in mind. I think that is the way
to do it. That way the code stays similar for normal drivers, and we
have the workaround for buggy drivers (yes, I still consider qce-ga as
buggy and faulty).

> 
> Accédez au courrier électronique de La Poste : www.laposte.net ; 
> 3615 LAPOSTENET (0,34¤/mn) ; tél : 08 92 68 13 50 (0,34¤/mn)
> 
> 
> 
> _______________________________________________
> Gnomemeeting-devel-list mailing list
> Gnomemeeting-devel-list gnome org
> http://mail.gnome.org/mailman/listinfo/gnomemeeting-devel-list
-- 
 _	Damien Sandras
(o-	GnomeMeeting: http://www.gnomemeeting.org/
//\	FOSDEM 2003:  http://www.fosdem.org
v_/_	
	H.323 phone:  callto://ils.seconix.com/dsandras seconix com