Re: [GnomeMeeting-devel-list] [PATCH] (src/)menu.h and (lib/)gtk_menu_extensions.h

[PUYDT Julien <julien puydt laposte net>]

On lun, 2004-04-05 at 14:59, Damien Sandras wrote:

> > those where always both included, while in some cases, only one was
> > really used directly. That patch fixes that.
> I don't understand what you mean.

Every .cpp that did something with menu was doing:
#include "menu.h"
#include "gtk_menu_extensions.h"
even if:
#include "menu.h"
or
#include "gtk_menu_extensions.h"
would have been enough.

> > Of course, I kept both included even if menu.h includes
> > gtk_menu_extensions.h: it is good to see direct dependancies at the
> > beginning of the files!  
> 
> My policy is that if a function from a header is included in a .cpp
> file, the header must be included even though it is already included
> through another file. If your patch doesn't break this, you can commit
> it as cleanup.

That sounds like what I explained, so I guess my patch is good ;-)

No account in sight yet.

Snark