Hello there are a few problems (most of them minor) with this patch : 1) The chat window is a GtkWidget which is part of the GmWindow. It means that you should have a pointer to that GtkWidget inside GmWindow and that you should not have functions like GnomeMeeting::Process ()->GetTextChatWindow (). Such functions are only for top-level windows, not for internal widgets inside those windows. 2) + /* delete (chat_window); unneeded: embedded in the main window! */ If it is unneeded, why don't you remove the line instead of committing it to CVS? ;) 3) + /* the rest of the structure is automatically freed: + * the main window has the chat_window, and the chat_window has them + */ +} That's not right, how could it be automatically freed? There is a leak here. 4) Please don't forget to add forward declarations in C code at the top of the file. The rest is like we have discussed it... Le mar 06/04/2004 à 14:37, PUYDT Julien a écrit : > Hi, > > the following patch does several things: > * it modifies the api of the gnomemeting_text_chat_* functions to get a > GtkWidget* as first argument (except _new, of course), that is the chat > window, to which the chat's data is attached; > * it makes the format of the chat's data private; > * it modifies the rest of gm to cope with those changes (!). > > Snark -- _ Damien Sandras (o- GnomeMeeting: http://www.gnomemeeting.org/ //\ FOSDEM: http://www.fosdem.org v_/_
Attachment:
signature.asc
Description: Ceci est une partie de message =?ISO-8859-1?Q?num=E9riquement?= =?ISO-8859-1?Q?_sign=E9e=2E?=