Re: [GnomeMeeting-devel-list] 1.00 Freeze
- From: Damien Sandras <dsandras seconix com>
- To: gnomemeeting-devel-list gnome org
- Subject: Re: [GnomeMeeting-devel-list] 1.00 Freeze
- Date: Tue, 27 Jan 2004 11:17:18 +0100
Le mar 27/01/2004 à 11:11, Miguel Rodríguez a écrit :
> I don't think this is the right way to fix this. We already have the
> gconf_test_age to check schemas are installed. This prevents errors in
> 90% of the cases. In the end, I don't think this was a good idea, as a
> result gm doesn't check for improper values in many places, and I have
> my share of guilt for this. Code should be robust against broken gconf
> keys, and check for NULLs whenever it gets a string, not just at
> startup. For two reasons:
> 1) Strings can be changed after startup
> 2) Correctness.
> The correct fix here is to audit the code and add the appropriate tests
> when strings (or other gconf values) are used, reverting to hardcoded
> values or ignoring things when they are wrong.
> I wish I could help more on this :(
That code audit is part of the fix, but that is just another protection.
It happens frequently that gconf_test_age is correct, but other keys are
not.
> > - Add a test on the openh323 and pwlib versions in gnomemeeting and in
> > configure.in
> >
> > Please don't put any patch from now in CVS.
> >
> > Julien, I think we have to postpone some of our ideas for 1.2.
> _______________________________________________
> Gnomemeeting-devel-list mailing list
> Gnomemeeting-devel-list gnome org
> http://mail.gnome.org/mailman/listinfo/gnomemeeting-devel-list
--
_ Damien Sandras
(o-
//\ It-Optics s.a.
v_/_ GnomeMeeting: http://www.gnomemeeting.org/
FOSDEM 2004: http://www.fosdem.org
H.323 phone: callto:ils.seconix.com/dsandras seconix com
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]