Am Sonntag, 21. März 2004 11:38 schrieb Damien Sandras: > Hi Stefan, > > Is it the code using the XV extension you were talking about? No, it is still working in RGB color space, using Xv will need more work, and Xv will not be available always, so this should be available to. Using Xv needs big rewrites of gdkvideoio, at the moment this is really hard to understand (although I figured it out) as there are really many different code pathes. I have some ideas to make this easier, but this will need some time. Am Sonntag, 21. März 2004 11:41 schrieb Damien Sandras: > Hi again, > > 2 suggestions : > - Do not use #if SDL_CONV, we can always use your code. > - I wouldn't introduce 2 new separate files for the unique method doing > the conversion, I would rather include it in the main class. > > After those changes, the patch can go in. As I was not 100% sure if this works in every case, I wanted to leave the old code in to make it easily accesible for cross checks. The reason for putting it in extra files was that I have developed it in a small code basis out of gnomemeeting (as gnomemeeting unfortunately does not run in valgrind, which has become my favourite performance measuring tool). So I simply copied the file into the gnomemeeting tree and called the function from gm ... I have no problems with putting it into the gdkvideo.cpp directly, the chosen way only was the simpler one for me. I can make a different patch, if you want ... Greets, Stefan -- Stefan Brüns / Kastanienweg 6 - Zimmer 1206 / 52074 Aachen mailto:lurch gmx li http://www.kawo1.rwth-aachen.de/~lurchi/ phone: +49 241 169-4206 mobile: +49 160 7532733
Attachment:
pgph6qLlZ498P.pgp
Description: signature