Le ven, 07/05/2004 à 16:13 +0200, PUYDT Julien a écrit : > On ven, 2004-05-07 at 15:16, Damien Sandras wrote: > > See my mail Sun, 02 May 2004 19:28:07 +0200 > > > > The same problem is still tehre. Moreover, your functions are not > > prefixed by gm_ or gnomemeeting_. Finally, I'm not ok with the way you > > pass your arguments to the callbacks, but you know what I mean, we > > already have discussed it a lot together and I won't rediscuss it > > again... > > Well, all functions visible from outside of src/druid.cpp begin with > gnomemeeting_druid_ and that api respects the > GtkWidget-as-first-argument idea. That should be the same for callbacks. Your name changes to the callbacks are very hard to read, I even wonder why you changed them, but well, if you like renaming functions, that's not a problem for me, just try to respect the document on the wiki from now. > > About the callbacks' arguments: as discussed yesterday, I can't get the > GmDruidWindow* through a g_object_get_data on the widget that received > the signal, because the druid window isn't the target of that signal! > You can use the GnomeMeeting::Process () thing, but I have redefined rules on the wiki, please have a look. I'm not persuaded it is in any way "better" or "more readable", but at least we now have rules to respect. Tell me when you are ready to work on new functionnalities. Code reorganizations are good but do not make the project progress unfortunately :( > Snark > > _______________________________________________ > Gnomemeeting-devel-list mailing list > Gnomemeeting-devel-list gnome org > http://mail.gnome.org/mailman/listinfo/gnomemeeting-devel-list
Attachment:
signature.asc
Description: Ceci est une partie de message =?ISO-8859-1?Q?num=E9riquement?= =?ISO-8859-1?Q?_sign=E9e?=