Re: [GnomeMeeting-devel-list] Re: Congratulations. You are the winner.

[Damien Sandras <dsandras seconix com>]

Le vendredi 15 avril 2005 à 11:45 +0200, Jan Schiefer a écrit :
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
> 
> Works. :D
> 
> Btw, you should replace
> 
>    if (!transport.bad() && !transport.eof()) {
>     transport.SetReadTimeout(3000);
>     transport >> cmd >> mime;
>   }
> 
>    if (transport.bad() || transport.eof()) {
>     PTRACE_IF(1, transport.GetErrorCode(PChannel::LastReadError) !=
> PChannel::NoError,
>               "SIP\tPDU Read failed: " <<
> transport.GetErrorText(PChannel::LastReadError));
>     return FALSE;
>   }

Actually it should even be :
   if (transport.bad()) {
    PTRACE_IF(1, transport.GetErrorCode(PChannel::LastReadError) !=
PChannel::NoError,
              "SIP\tPDU Read failed: " <<
transport.GetErrorText(PChannel::LastReadError));
    return FALSE;
  }

An eof() being normal even when you read a PDU.

I have committed both changes to CVS. If you had time to recompile in
one day or two to make sure it still works, I would be happy.

Thanks for your debugging, things are progressing thanks to guys like
you!
-- 
 _      Damien Sandras
(o-     GnomeMeeting: http://www.gnomemeeting.org/
//\     FOSDEM 2005 : http://www.fosdem.org
v_/_    H.323 phone : callto:ils.seconix.com/dsandras seconix com