Re: [GnomeMeeting-devel-list] Patch for Openh323 and gcc4

[Daniel Veillard <veillard redhat com>]

On Sat, Mar 19, 2005 at 02:29:32AM +1100, Craig Southeren wrote:
> 
> On Fri, 18 Mar 2005 09:46:01 -0500
> Daniel Veillard <veillard redhat com> wrote:
> 
> >   Hi Damien and all,
> > 
> > Sorry it's not pure development informations, but since I had a patch
> > I though it was the right place to post.
> 
> The OpenH323 list would be a better place, and the Openh323 bug tracker
> on SourceForge would be even better :)

  okay, okay :-)

> > I rebuilt pwlib-1.8.4 / openh323-1.15.3 / gnomemeeting-1.2.1 
> > for Fedora Core 4 with gcc4. 
> 
> I did a test build using gcc 4 several weeks ago without any problems.
> 
> Can you tell me what gcc version you are using?

  gcc version 4.0.0 20050314 (Red Hat 4.0.0-0.34)
It did show up on the x86_64 host, possibly because it was the first one
to reach the error.

> > It's nearly clean, the main problems
> > remaining are:
> >    - cast from pointers to int in openh323 that gcc4 considers a
> >      fatal error now (apparently it wasn't fixed in CVS as far as
> >      I can tell so patch enclosed)
> 
> One of these patches was applied to the current CVS several weeks ago.
> The patch to speexcodec.cxx looks very weird - I'd like to see that
> cleaned up.

  I didn't want to cast directly to the int, as I wanted to be sure my build
would go though. That's why I used an intermediate long variable. The compiler
should optimize it out anyway.

  I just checked the speexcodec.cxx when comparing with CVS, the other
one was looking trivial.

> >    - the config.guess of pwlib is so old that doesn't seems to know
> >      about ppc64, maybe an update at the next release would be a good idea
> 
> I guess I need a new autoconf on my system :)

  Possibly, I think I saw 2001 on the one shipped, once every 4 years it's
worth going though the pain :-)

> >    - removing symbol tables in pwlib/make/unix.mak break our debuginfo
> >      LDFLAGS += -s
> >      has to be removed in our build, no idea if it annoys anybody else
> 
> IIRC, this was removed in the latest CVS

  Okay, thanks,

Daniel

-- 
Daniel Veillard      | Red Hat Desktop team http://redhat.com/
veillard redhat com  | libxml GNOME XML XSLT toolkit  http://xmlsoft.org/
http://veillard.com/ | Rpmfind RPM search engine http://rpmfind.net/