[GnomeMeeting-devel-list] Questions on gnomemeeting-opal's src/endpoint.cpp

[Julien PUYDT <jpuydt free fr>]

Hi,

I tried reading src/endpoint.cpp to see how it now looks, and have 
several questions/remarks:
1) the function GetRegisteredAccounts uses an ill-named int "sip" to 
denote an integer which in fact adds h323 and sip accounts' numbers ; I 
propose the following trivial patch to rename it to "number":
@@ -2554,13 +2554,13 @@
 int
 GMEndPoint::GetRegisteredAccounts ()
 {
-  int sip = 0;
+  int number = 0;

-  sip = sipEP->GetRegisteredAccounts ();
+  number = sipEP->GetRegisteredAccounts ();
   if (h323EP->IsRegisteredWithGatekeeper ())
-    sip++;
+    number++;

-  return sip;
+  return number;
 }


2) SetTransferCallToken and GetTransferCallToken don't use 
PWaitAndSignal but explicitly do the Wait, something, then the Signal ; 
why is it so?
3) I don't understand what all those "pc:" thingies are about (as seen 
in AddRouteEntry or OpalManager::SetupCall function calls.

I wonder if my next step will be reading some more opal or some more 
gnomemeeting-opal :-/

Snark