Re: [Fwd: [GnomeMeeting-list] [PATCH] Better integration with Video4Linux for PWLIB]

[Damien Sandras <dsandras seconix com>]

Le dim 21/09/2003 à 23:27, Chris Rankin a écrit :
>  --- Damien Sandras <dsandras seconix com> wrote:
> > My worry with the current patch is that other buggy
> > drivers could also
> > report wrong default values after the VIDIOCGWIN
> > ioctl.
> 
> My theory is that it's better to start from a "known
> good" position. With the pwc module at least, you can
> configure the defaults using module parameters. So the
> patch would give the user a chance to "do something"
> to make the driver work.

I agree, but the max. width and max. height returned by the driver
should be correct, while nothing makes sure that the driver will return
correct current width and height. They could be unitialized when loading
the driver and that would still not be a bug. 

The Video4Linux API says that max. width and max. height correspond to
the maximum values supported by the driver.

However, VIDIOCGWIN will report the current width and height which could
contain random values for other drivers just after they are loaded.

So yes, the patch is a nice workaround to the pwc bug, but I don't think
it is a good generic patch.
-- 
Damien Sandras <dsandras seconix com>