Re: [GnomeMeeting-list] [PATCH] Better integration with Video4Linux for PWLIB

["Nemosoft Unv." <nemosoft smcc demon nl>]

Hello,

On Monday 22 September 2003 00:02, Derek Smithies wrote:
> Chris,
>  Modifying kernel code, or adding module parameters, are a pain.

Not really. You can always send a patch to the apropriate maintainer (that 
would be me :))) It will then eventually percolate into kernels on user's 
systems. The most important thing is not to break (too many) existing 
applications.

[...]

>  You see, it means that anyone else who uses the QuickCam has to do the
> same.
>
> Your patch is "fine", in that it works.
> However, I really really don't want to add it, cause that will change the
> operation of the pwlib v4l code for all cameras.
>
> Can I suggest that you modify your patch, so that it uses the hint table,
> line 200 of video4linux.cxx
> Modify the hint table so it includes a section for your QuickCam camera.
> and put a new hint in the hint table.
>
> The new hint is
>     HINT_USE_CURRENT_HARDWARE_SIZE 0x0400
>
> Then,  you have in your changes.
> if (HINT (HINT_USE_CURRENT_HARDWARE_SIZE)) {
>    your code;
>  } else {
>     previous code;
>  }
>
>
> Thus, if the camera is QuickCam, it uses your code.
>      if the camera is anything else, nothing changes.

If I may? First off, I think it's a bad idea to put too much camera specific 
code in your program. Second, if you do it, try to do it in the most 
general way possible. The QuickCam is using my PWC driver, and although I 
admit that driver is slightly "broken" in this case, your code should then 
work on all PWC supported cams, since they all suffer from the same 
problem, in which case I'm happy to point you to my API document on 
http://www.smcc.demon.nl/webcam/api.html which includes a PWC detection 
routine. 

 - Nemosoft

-- 
Linux Philips webcam driver page: http://www.smcc.demon.nl/webcam/
Includes FAQs, links to working programs and lots of info.