Re: libgsf, GsfInfileZip

[Jody Goldberg <jody gnome org>]

On Thu, Jul 25, 2002 at 02:07:33PM +0300, Tambet Ingo wrote:
> This patch does:
> * Implements zip file reading.
> * Adds two tests for gsf-infile-zip.
Lovely.
 
> Also, while reading gsf-infile-msole, I wondered if this is correct:
>
> ...
> static gboolean
> ole_init_info (GsfInfileMSOle *ole, GError **err)
> {
> ...
> ...
>
>       if (err != NULL)
>               *err = g_error_new (gsf_input_error (), 0,
>                       "No OLE2 signature");
> ...
> }
>
>
> Doesn't g_error_new make a new GError?
Yes.  The caller is passing a GError **.
This seemed to be the common idiom in gtk and gconf.

> Index: gsf/gsf-infile-zip.c
> ===================================================================
The code looks good, please commit so that we can play with it.