USE_HILDON

[Morten Welinder <mwelinder gmail com>]

There are currently too any "#ifdef USE_HILDON" occurences in the Gnumeric
source code.  There really should not be any, just like "#ifdef linux"
is frowned
upon.

They need to be replaced with something more specific.  For example, the one
in gnumeric_arg_parse (src/main-application.c):

#if defined (WITH_GNOME) || defined (USE_HILDON)
        gnome_vfs_init ();
#endif

should probably be turned into

#ifdef WITH_GNOMEVFS
        gnome_vfs_init ();
#endif

and suitable magic should go into configure.in.

In src/gui-file.c, it looks like a HAVE_HILDON_FILE_CHOOSER_DIALOG_NEW would be
better, at least for some of the items.  Maybe.  The changes to
gui_wb_view_show could
use some commenting as to why something different is being done.

Over in src/workbook-control-gui.c, in looks like some
PRESERVE_SCREEN_REAL_ESTATE
setting would help.

The point is that as long as it is under USE_HILDON, we are going to break it
(unintentionally) over and over again.  And we cannot test if even if
we want to.
Those parts that make sense everywhere, such as PRESERVE_SCREEN_REAL_ESTATE,
we could test.  And the next device with limited screen space that comes around
could reuse the pruning that has been done.

Comments?

Morten