Re: GNOME CVS: glib yosh



> > Log message:
> > * config.h.win32 (new file)
> > * glibconfig.h.win32
> > * glib.def
> > * makefile.msc: applied glib-tml-981104, win32 sync
> 
> Now that there's a handcrafted `glibconfig.h.win32', does is make sense
> to push all those
> 
> 	#pragma warning
> 
> in there, so that `glib.h' is less cluttered?  

Yeah, those are M$ Visual C++ specific.

> Another thing we can do is, in `glib.h', say
> 
> 	#ifndef G_DIR_SEPARATOR_S
> 	# define G_DIR_SEPARATOR_S "/"
> 	#endif
> 
> 	#ifndef G_SEARCHPATH_SEPARATOR_S
> 	# define G_SEARCHPATH_SEPARATOR_S ":"
> 	#endif
> 
> 	#define G_DIR_SEPARATOR		G_DIR_SEPARATOR_S[0]
> 	#define G_SEARCHPATH_SEPARATOR	G_SEARCHPATH_SEPARATOR_S[0]
> 
> and 
> 
> 	#define G_DIR_SEPARATOR_S "\\"
> 	#define G_SEARCHPATH_SEPARATOR_S ";"
> 
> in glibconfig.h.win32.  The idea being to have fewer and fewer
> occurances of `#ifdef WIN32' in `glib.h'.

Now these are Windows specific, but on cygwin, it generates it's own
glibconfig.h. So we would have to stick this in the glibconfig.h creation
mechanism as well.

-Yosh



[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]