Re: Small bug in gtknotebook.c



On Thu, Nov 26, 1998 at 12:27:25PM -0500, Owen Taylor wrote:
> 
> Dave Cole <dave@dccs.com.au> writes:
> 
> > When trying a program of mine with gtk+-1.1.5, I encountered a
> > segfault in gtknotebook.c
> > 
> > I do not have CVS access, so could someone have a look at this patch,
> > then apply it if it is correct?
> 
> Do you have example code that triggers the problem, or an
> an explaination of how it is triggered? 
> 
> Patches that "randomly" add in != NULL checks always make me a bit
> nervous, because it isn't clear that they aren't just glossing
> over the real problem.

I think the bug occured because two checks on notebook->show_tabs == TRUE
were missing (tab_labels will be != NULL then). So it should be fixed now.
(hopefully ;)

bye,
  Lars



[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]