Re: [PATCH] Clean up `glibconfig.h'

[Tim Janik <timj gtk org>]

On 25 Oct 1998, Raja R Harinath wrote:

> 
> I have uploaded 
> 
> 	glib-rrh-19981025-0.patch.gz
> 
> to ftp.gtk.org:/incoming.

ok, i just read through your patch and only found a few minor issues:
- g_memmove, please still provide the exact prototype of this function
  in the comment (so one doesn't have to look it up in glibconfig.h), i.e.
  void g_memmove(gpointer src, gpointer dest, guint size).
- g_ATEXIT/ATEXIT, is this really worth keeping? use of this macro is abandoned
  for a variaty of reasons (glib shouldn't provide macros outside of it's
  namespace and use of ATEXIT() still requires system dependant header files
  which may vary depending on the target platform). i'd rather see ATEXIT() to
  completely vanish, since we provide a function g_atexit() that takes care of
  portability issues.
- why are the #include <config.h> lines wrapped by an #ifdef HAVE_CONFIG_H
  statement? with your new scheme, glibconfig.h and config.h are always in
  place.
  
ok raja, except for the above issues, i think your patch should be applied.
but since a few checks in gdk need to be changed aftewards, and snorfle's is
going to make a new release of gtk which will depend on the glib 1.1.4 from
last weekend, we'll have to wait for the upcoming gtk release to be made.
i'll move glib-rrh-19981025-0.patch.* to patches/outdated, since it doesn't
cleanly apply anymore (after the windows stuff is in there as well now).
since you have commit access to the repo (and are touching virtually any cvs
module's auto* section anyways ;), i'd like to see you commit this stuff
yourself next time, rather than providing a new patch.

> 
> - Hari
> 

---
ciaoTJ