No Subject

[Owen Taylor <otaylor redhat com>]

Cc; Anders Carlsson <andersca@gnu.org>
Subject: Re: [PATCH] Mouse wheel events for gtk+ 1.3
References: <38A5B59C.90CD8395@gnu.org>
From: Owen Taylor <otaylor@fresnel.labs.redhat.com>
Date: 17 Feb 2000 12:39:02 -0500
In-Reply-To: Anders Carlsson's message of "Sat, 12 Feb 2000 14:33:48 -0500"
Message-ID: <ybek8k3ohjd.fsf@fresnel.labs.redhat.com>
Lines: 41
User-Agent: Gnus/5.0802 (Gnus v5.8.2) Emacs/20.4
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii


Anders Carlsson <andersca@gnu.org> writes:

> Hello,
> 
> at the URL
> http://info.stjerneskolan.com/~andersca/gnome/mouse_wheel-gtk-1.3.diff.gz
> you can find a patch that gives mouse wheel events their own GdkEvent
> structure. The patch also adapts the widgets that use mouse wheel events
> to the new event.
> 
> This should make it easier to port GTK+ to different platforms since not
> all window systems use buttons 4 and 5 to signal mouse events.
> 
> Please note that this is my first serious GTK+ hacking attempt, if
> there's anything thats wrong, tell me :)

In general it looks good. There are few minor slipups

 - Use of | instead of ||
 - Wrong brace style. GNU-style indentation is mandatory for GTK+
 
As for the content of the patch, it looks reasonable. There are
a few things that need to be changed before applying it:
 
 - I don't think GtkLayout should handle scroll events itself. 
 - OwnerGrabButtonMask should not be in the event mask
 - Since you've put 4 values into the direction enumeration, you
   should handle them properly everywhere.
 - There should be no gtk_widget_real_scroll_event() - GTK+ has 
   a mechanism for event propagation already.

But it is probably close enough that I can go ahead and apply it
without another iteration. Let me know if you have any objections
to the above changes.

Regards,
                                        Owen