Some headerfiles patches



[Based on CVS source of today]

Hi,

Whilst trying to clean up some code I added my usual bunch of -W flags
to gcc 2.95.2 and encountered some header file problems.

The flags I used were:

ansi -pedantic -Wall -Wundef -Wredundant-decls -Wnested-externs \
-Wstrict-prototypes -Wpointer-arith -Winline -Wcast-qual \
-Wmissing-prototypes

And the -Wredundant-decls triggered some warnings.

In this case some double function prototypes and some prototypes with no
declarators.

See attached patches.

I think I saw this one come up already on the list:

gtktypeutils.h

typedef void (*GtkSignalFunc)      ();

This should probably just be

typedef void (*GtkSignalFunc)      (void);

gtkitemfactory.h:

typedef void    (*GtkItemFactoryCallback)  ();

to

typedef void    (*GtkItemFactoryCallback)  (void);

If/when I encounter some more I'll send some more patches.

Cheers,

-- 
Jeroen Ruigrok van der Werven/Asmodai           asmodai@[wxs.nl|bart.nl]
Documentation nutter.          *BSD: Technical excellence at its best...  
The BSD Programmer's Documentation Project <http://home.wxs.nl/~asmodai>
We must all hang together, else we shall all hang separately...
--- gtk/gtkmenu.h.orig	Sun Jan 16 16:38:07 2000
+++ gtk/gtkmenu.h	Sun Jan 16 17:06:42 2000
@@ -146,7 +146,6 @@
  */
 GtkWidget* gtk_menu_get_attach_widget	  (GtkMenu	       *menu);
 
-void	   gtk_menu_detach		  (GtkMenu	       *menu);
 void       gtk_menu_set_tearoff_state     (GtkMenu             *menu,
 					   gboolean             torn_off);
 
--- gdk/gdkdnd.h.orig	Sun Jan 16 18:27:45 2000
+++ gdk/gdkdnd.h	Sun Jan 16 18:36:33 2000
@@ -91,8 +91,6 @@
 void            gdk_drag_abort       (GdkDragContext *context,
 				      guint32         time);
 
-GdkAtom       gdk_drag_get_selection (GdkDragContext *context);
-
 #ifdef __cplusplus
 }
 #endif /* __cplusplus */


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]