Re: gtk-hp-patches

[Havoc Pennington <hp redhat com>]

Owen Taylor <otaylor@redhat.com> writes: 
> I'd agree it's a bigger patch than I like, but since both 
> of us (especially me) have posted patches of this size
> which _don't_ split into neat chunks, I'm not too worried
> in the big picture. The real problem is basically that we
> never gave Havoc a final gohead to commit various parts
> of this patch as he finished them.  
>  

Yes. Tim, the problem is that most of these patches depend on each
other (dialog/messagedialog requires stock icons requires style
changes requires iconset/icon source requires pixbuf). Similarly for
GObject in GDK; that stuff was all tied together, the patch couldn't
be separated. The text widget stuff in this patch is not related to
the rest, but it shouldn't require much review, since none of it is
worse than what's in head already.

I'm pretty sure almost all the stuff in that patch has appeared on
this list at least once before, sometimes more (e.g. GtkDialog has
been on here half a dozen times). But I never get commit approval, and
so my branch just keeps growing.

I apologize for the large patch, but really, there is not much
alternative.

I'll incorporate all the suggestions from you and Owen tomorrow, and
get a final patch together.

Havoc