Re: a possible bug of gtk_drag_set_default_icon()?

[Owen Taylor <otaylor redhat com>]

KUSANO Takayuki <AE5T-KSN@asahi-net.or.jp> writes:

> My friend pointed me out that gtk_drag_set_default_icon() in
> gtk+/gtk/gtkdnd.c has a bug. He said,
> 
> --- gtkdnd.c.orig	Sun Jun 11 21:28:53 2000
> +++ gtkdnd.c	Sun Jun 11 21:29:04 2000
> @@ -2056,7 +2056,7 @@
>    if (default_icon_pixmap)
>      gdk_pixmap_unref (default_icon_pixmap);
>    if (default_icon_mask)
> -    gdk_pixmap_unref (default_icon_pixmap);
> +    gdk_pixmap_unref (default_icon_mask);
>  
>    default_icon_colormap = colormap;
>    gdk_colormap_ref (colormap);
> 
> This can be applied to both gtk+1.2 and gtk+1.3.
> Is this really a bug?

Yes, this is a bug.

I've fixed it now in CVS.

Thanks,
                                        Owen