Re: Patch to fix togglebuttons popping up

[Tim Janik <timj gtk org>]

On 31 May 2000, Havoc Pennington wrote:

> 
> Tim Janik <timj@gtk.org> writes:
> > On 30 May 2000, Soeren Sandmann wrote:
> > 
> > > Togglebuttons currently pops up when the mouse enters them, even if
> > > they are active. Here is a patch:
> > 
> > i don't understand, i'm not aware of any popup bugs with toggle buttons.
> > could you elaborate on the problem you sense?
> > 
> 
> The problem is that they are "pressed in" while active, but prelight
> is always "popped out" even if the button is active.

i'm sorry, i still don't understand. first, prelight changes the background
color, not the shadow, so how's prelighting making the button "pop out"?
second, i applied the patch and get exactly the same behaviour as before
(i couldn't tell how the patch would change the prelighting anyways),
i.e. an active toggle button with mouse entered is drawn with a prelight
background and a SHADOW_IN frame.

an argument could be made for mouse entered active toggles to draw their
background with NORMAL instead of prelight, since NORMAL is about as lighter
than ACTIVE as PRELIGHT is lighter than NORMAL for non-active toggles,
but the patch does not make an attempt at changing that.

> 
> Havoc
> 

---
ciaoTJ