Re: preview of the new GtkComboBox

[Havoc Pennington <hp redhat com>]

Hi,

Here are some random thoughts, based mostly on the headers, haven't
checked out the implemtation yet -

 - get rid of the spaces inside parentheses ( no spaces around this
   text )

 - I wouldn't expose GtkComboBoxGridItem, all its fields are private.
   Just use the widget instead:

    gtk_combo_box_grid_select_item (GtkComboBoxGrid *grid, 
                                    GtkWidget       *item);

   You can store the GtkComboBoxGridItem as an internal implementation
   detail. It might be convenient to set the GridItem as object
   data on the child widget in your implementation.

 - gtk_combo_box_grid_add () isn't needed, gtk_container_add() should
   be made to work here

 - gtk_combo_box_construct () should be replaced by object arguments
   eventually

 - If there's a popup_hide(), shouldn't there be a popup_show()? 
   What's the intended use of this method?

 - gtk_combo_box_set_sensitive() isn't needed; if you
   gtk_widget_set_sensitive() on a container, it automatically
   recursively sets sensitivity on children.

 - however, the previous behavior probably depends on implementing
   the forall virtual method from GtkContainer, which you should
   do

Havoc