gdk_property_change oddity



gtk+/gdk/x11/gdkproperty-x11.c contains :

>  g_return_if_fail (window != NULL);
>  g_return_if_fail (GDK_IS_WINDOW (window));

>  if (window)
     [do stuff]
>  else
     [do other stuff]

The g_return_if_fail (window != NULL) seems to make no sense
here.  Would it be ok to replace this checking with

   g_return_if_fail (!window || GDK_IS_WINDOW (window));

?

-- 
Robert Brady
robert suse co uk





[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]