Re: [PATCH] Segfault fix in pango

[Owen Taylor <otaylor redhat com>]

Anders Carlsson <andersca gnu org> writes:

> On 16 Apr 2001 11:57:38 -0400, Owen Taylor wrote:
> > 
> > This looks fine as far as it goes but glancing at the code there seems
> > to be various places where md->text is appended to without checking to
> > see if it is NULL.
> > 
> > It wouldn't be hard to fix these up, but talking it over
> > with Havoc, we don't think that people will really use
> > it with text == NULL. So, the better course (reduce complexity)
> > is to simply always compute md->text, remove the existing
> > if (md->text) checks and discard the result if text == NULL.
> > 
> > Feel free to commit a patch to that effect.
> > 
> > Regards,
> >                                         Owen
> > 
> 
> I've committed the attached patch. Let me know if there's something
> wrong with it.

The patch is fine. There were a couple of existing checks on
md->text == NULL that needed to be removed as well, which
I've done now.

Regards,
                                        Owen