Re: Code changes for glib to enhance 64-bit operation

[Pavel Machek <pavel suse cz>]

Hi!

> Index: testglib.c
> ===================================================================
> RCS file: /cvs/gnome/glib/testglib.c,v
> retrieving revision 1.49
> diff -u -r1.49 testglib.c
> --- testglib.c	2001/03/09 21:31:21	1.49
> +++ testglib.c	2001/04/18 18:06:22
> @@ -46,7 +46,7 @@
>  #include <io.h>			/* For read(), write() etc */
>  #endif
>  
> -static int array[10000];
> +static int array[10000];    /* 64-bit change: int -> long */

Ugh?

>  
> -static guint
> +static gulong    /* 64-bit change:  guint -> gulong */

I believe this comment is evil. Fix it, but do not put comment there.

								Pavel
What are you fixing btw?

>  my_hash (gconstpointer key)
>  {
> -  return (guint) *((const gint*) key);
> +  return (gulong) *((const gint*) key);  /* 64-bit change:  guint->gulong */
                       ~~~~~~~~~~~~~
			will not this spoil it?


-- 
I'm pavel ucw cz  "In my country we have almost anarchy and I don't care."
Panos Katsaloulis describing me w.r.t. patents at discuss linmodems org