Re: gtk_image_menu_item() API problems
- From: Martin Baulig <martin home-of-linux org>
- To: Havoc Pennington <hp redhat com>
- Cc: gtk-devel-list gnome org
- Subject: Re: gtk_image_menu_item() API problems
- Date: 28 Apr 2001 17:40:48 +0200
Havoc Pennington <hp redhat com> writes:
> Martin Baulig <martin home-of-linux org> writes:
> > i) allow the label argument of gtk_image_menu_item_new() be NULL and add
> > a property for it.
>
> Allowing NULL is good, the property is bad - we'd need such a property
> for GtkFrame, GtkButton, etc. as well. It's not really right, the
> _with_label() variants of everything are just convenience functions.
>
> If you want to change it later just create the label yourself and set
> the label.
How, should I add an accessor function for it or this property ?
> > ii) rename gtk_image_menu_item_add_image() to gtk_image_menu_item_set_image()
> > and fix it so that it'll actually change an image.
>
> Tim suggested this before, I think it's probably right.
>
> If you want to do a patch to allow NULL for the label (should make
> sure button_new (), etc. also allow that, and the mnemonic variants),
> and do set_image() that makes sense to me.
Ok.
--
Martin Baulig
martin gnome org (private)
baulig suse de (work)
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]