Re: Outstanding patches, #57549

[Owen Taylor <otaylor redhat com>]

"Matthias Clasen" <matthiasc poet de> writes:

> This is a fairly obvious patch which has the nice effect of  fixing
> segfaults from the font selector.
> Ok to commit ?

It looks OK to commit, but do you have any idea why this would
cause segfaults in the font selector? If this fixes a segfault,
then I think we have another bug somewhere.

Regards,
                                        Owen

> Matthias
> Index: gtk/gtkstyle.c
> ===================================================================
> RCS file: /cvs/gnome/gtk+/gtk/gtkstyle.c,v
> retrieving revision 1.70
> diff -u -3 -p -u -r1.70 gtkstyle.c
> --- gtk/gtkstyle.c	2001/07/22 20:09:00	1.70
> +++ gtk/gtkstyle.c	2001/07/30 10:53:55
> @@ -1508,6 +1508,7 @@ gtk_style_real_unrealize (GtkStyle *styl
>        gtk_gc_release (style->mid_gc[i]);
>        gtk_gc_release (style->text_gc[i]);
>        gtk_gc_release (style->base_gc[i]);
> +      gtk_gc_release (style->text_aa_gc[i]);
> 
>        if (style->bg_pixmap[i] &&  style->bg_pixmap[i] != (GdkPixmap*)
> GDK_PARENT_RELATIVE)
>  	gdk_pixmap_unref (style->bg_pixmap[i]);
> @@ -1520,6 +1521,7 @@ gtk_style_real_unrealize (GtkStyle *styl
>    gdk_colormap_free_colors (style->colormap, style->mid, 5);
>    gdk_colormap_free_colors (style->colormap, style->text, 5);
>    gdk_colormap_free_colors (style->colormap, style->base, 5);
> +  gdk_colormap_free_colors (style->colormap, style->text_aa, 5);
>  }