Re: --include-deps



Owen Taylor wrote:

A bunch of the patches you've submitted include changes to
autogen.sh like:

+case $CC in
+*xlc | *xlc\ * | *lcc | *lcc\ *) am_opt=--include-deps;;
+esac
+if test -n "$CC" && echo $CC | grep -v gcc >/dev/null 2>&1; then
+        $CC -v 2>&1 | grep gcc || am_opt=--include-deps
+fi
+

The two halves of this seem be rather unrelated and tacked
together, and this will, among other things result in parts
of gcc -v being printed to standard out in some cases. Is the intent supposed to be something like:

if test -n "$CC" ; then
 my_cc=$CC
else
 my_cc=cc
 IFS="${IFS= 	}"; save_ifs="$IFS"; IFS="${IFS}:"
 for dir in $PATH; do
   if test -x $dir/gcc ; then
     my_cc=gcc
   fi
 done
 IFS="$save_ifs"
fi

case $my_cc in
*xlc | *xlc\ * | *lcc | *lcc\ *) am_opt=--include-deps
   ;;
 *gcc | *gcc\ *)
   ;;
 *)
   $CC -v 2>&1 | grep gcc > /dev/null || am_opt=--include-deps
   ;;
esac
Regards,
                                       Owen

I was planning on rewriting it much like this, but I had done the quickest hack I could to get it to realize my CC is no gcc.

--
Frank







[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]