Re: gobject profile ... (fwd)

[Alex Larsson <alexl redhat com>]

On Fri, 24 Aug 2001, Michael Meeks wrote:

> 	Anway - as you can see, we hit a lot of things before anything I
> have control over (superficialy, although clearly not algorithmicaly). And
> worse - it seems that locking is swallowing a huge chunk of the time, far
> outweighing anything else - at 40% of the time ... :-)

Yeah. Whenever i profile anything i get a huge blob in gtype.c. I 
think/hope tim is working on this though.
 
> 	So. It seems over the codebase, mostly we have constructs of the
> type:
> 	static GMutexType *amutex = NULL;
> ...
> 	if (g_thread_supported ())
> 		amutex = new_mutex ();
> ...
> 	if (amutex)
> 		take_lock (amutex);
> 
> 	etc. which seems to serve us well and good for Gdk etc. etc.
> 
> 	So is there any good reason why the type_rw_lock in gtype.c is not
> handled this way ? I'm happy to pay the locking penalty if I'm using it,
> but ...

I'd rather fix it to not do as much locking. To finegrained locking 
*really* hurts performance.

/ Alex