Re: gdk_pixbuf_loader_write and short files

[Havoc Pennington <hp redhat com>]

Matthias Clasen <matthiasc poet de> writes:
> +    retval = gdk_pixbuf_loader_load_module (loader, NULL, error);
>

We need to be sure we always return without reusing "error" here. 
i.e. if there's an error stop_load should not be called.

This probably means you need a temporary error variable so you can
check whether an error occurred, even if error == NULL.
Because if the app passes in NULL to ignore errors, control flow
should not be affected.

(Rationale is in the GError docs if you're interested.)

Havoc