Re: ink_rect and logical_rect; bug or feature?



Darin Adler <darin bentspoon com> writes:

> On 12/19/01 6:38 PM, "Owen Taylor" <otaylor redhat com> wrote:
> 
> > The coordinates for pango_layout_get_[pixel]_extents are from
> > the upper left of the layout, for both the ink and the logical
> > rect. (On the other hand, for layout_line_get_extents, the
> > origin is on the baseline.)
> 
> But if ink_rect is supposed to be relative to the top left, then I think I
> see a bug in get_line_extents_layout_coords, because when line ==
> layout->lines->data, it does line_ink_layout->y = line_ink->y, and I can't
> see how that can possibly be right.

Yeah, I don't know what the special casing of the first
line was intended to do. I've removed it now in CVS.

Thanks,
                                        Owen



[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]