Re: Patches to gtkwidget and gtkwindow for property support

[Owen Taylor <otaylor redhat com>]

John Margaglione <jmargaglione yahoo com> writes:

> Here are my changes to GtkWidget and GtkWindow.  I converted the args to
> properties using g_type support.  Let me know if they are ok, and I will
> continue with the other files. 

You'll need to redo that patch as a unified diff (diff -u). On the
scale of patch formats:

  Unified: good

  Context: OK, but not what we use, and a bit harder to read

  Default: Unreadable, unuseable

> The only open question I have is when to
> use g_object_notify.  Some of the files (gtktexttag.c) use it, and some
> (gtkcellrenderer.c) don't.

I don't know the details of how to use g_object_notify() - maybe
Tim can write a summary. But the idea is that notification should
always happen, so when properties change, especially not through
the property interface ,you need to add calls to g_object_notfiy.

Regards,
                                        Owen