Re: gboolean patch



Thus spake Owen Taylor:
> While going through old back patches, I noticed that your
> gint => gboolean patch was never applied.
> 
> (http://bugzilla.gnome.org/show_bug.cgi?id=51041)
> 
> It looks mostly correct, but there is a problem with quite
> a few occurrences of:
> 
>  -  guint          show_text : 1;
> -  guint          activity_mode : 1;
> +  gboolean      show_text : 1;
> +  gboolean      activity_mode : 1;
> 
> Which is incorrect, since to hold the values FALSE and TRUE,
> a bitfield must be unsigned, and gboolean is signed.

right -- this was brought up...
also, I missed a few and someone else pointed them out (in a later
thread...)

> Do you think you'll have the chance to fix this and update
> the patch to the latest CVS, or does someone else needs
> to take this on?

sure -- how should I go about this?
clearly I need to update to latest CVS, but I don't know the best way
to fix up a patch -- do I just try applying it, then clean up/edit the
resulting mess, or is there a better way?

-- 
  -nils
Public key: http://www.nbarth.net/~nbarth/pub-key.txt

Attachment: pgpMjzmsnkugW.pgp
Description: PGP signature



[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]