Some small bugs



When the selectability of a GtkLabel is changed, it must queue a redraw,
since it might have something selected:

Index: gtk/gtklabel.c
===================================================================
RCS file: /cvs/gnome/gtk+/gtk/gtklabel.c,v
retrieving revision 1.73
diff -u -p -r1.73 gtklabel.c
--- gtk/gtklabel.c	2001/02/17 17:21:21	1.73
+++ gtk/gtklabel.c	2001/02/20 13:28:15
@@ -1306,6 +1306,7 @@ gtk_label_set_selectable (GtkLabel *labe
           label->select_info = NULL;
         }
     }
+  gtk_widget_queue_draw (GTK_WIDGET (label));
 }
 
 gboolean


Apparently pixmap_node->mask_plus/minus are NULL here, giving a CRITICAL
warning:

Index: gtk/gtktreeitem.c
===================================================================
RCS file: /cvs/gnome/gtk+/gtk/gtktreeitem.c,v
retrieving revision 1.44
diff -u -p -r1.44 gtktreeitem.c
--- gtk/gtktreeitem.c	2001/01/31 03:51:13	1.44
+++ gtk/gtktreeitem.c	2001/02/20 13:28:16
@@ -451,9 +451,11 @@ gtk_tree_item_remove_pixmaps (GtkTreeIte
 	{
 	  gdk_colormap_unref (pixmap_node->colormap);
 	  gdk_pixmap_unref (pixmap_node->pixmap_plus);
-	  gdk_bitmap_unref (pixmap_node->mask_plus);
+	  if (pixmap_node->mask_plus)
+	    gdk_bitmap_unref (pixmap_node->mask_plus);
 	  gdk_pixmap_unref (pixmap_node->pixmap_minus);
-	  gdk_bitmap_unref (pixmap_node->mask_minus);
+	  if (pixmap_node->mask_minus)
+	    gdk_bitmap_unref (pixmap_node->mask_minus);
 	  
 	  pixmaps = g_list_remove_link (pixmaps, tree_item->pixmaps);
 	  g_list_free_1 (tree_item->pixmaps);

Can i check this in?

/ Alex






[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]