Re: dragging bug caused by fix for GtkInvisible style attach leak

[Alexander Larsson <alla lysator liu se>]

On 2 Jan 2001, Owen Taylor wrote:

> > Index: gdkwindow.c
> > ===================================================================
> > RCS file: /cvs/gnome/gtk+/gdk/gdkwindow.c,v
> > retrieving revision 1.80.2.9
> > diff -u -p -r1.80.2.9 gdkwindow.c
> > --- gdkwindow.c	2000/01/27 21:10:44	1.80.2.9
> > +++ gdkwindow.c	2001/01/02 10:11:58
> > @@ -401,7 +401,7 @@ gdk_window_new (GdkWindow     *parent,
> >      {
> >        depth = 0;
> >        class = InputOnly;
> > -      private->colormap = NULL;
> > +      private->colormap = gdk_colormap_get_system ();
>
> Hmm, like Havoc's patch, I think you need the ref here. (Looking
> at this, there are some problems with refcounting, colormaps
> and drawables in head, but for stable, things should be simple.)

What do you mean? 10 lines later is does:
  if (private->colormap)
    gdk_colormap_ref (private->colormap);

/ Alex