Re: fixing gdk-pixbuf image loaders



> > Havoc Pennington wrote:
> > > 
> > > Hi,
> > > 
> > > For GTK 2.0 we want the pixbuf image loaders to be robust against
> > > corrupt image data. At the moment, some of them are completely broken
> > > ("gee, I have a number from the network - let's dereference this array
> > > with it!").

Well, it's not a robustness thing, but here's a memory leak fix instead.

iain



? INSTALL
? COPYING
Index: ChangeLog
===================================================================
RCS file: /cvs/gnome/gdk-pixbuf/ChangeLog,v
retrieving revision 1.256
diff -U2 -r1.256 ChangeLog
--- ChangeLog	2000/12/08 20:02:12	1.256
+++ ChangeLog	2001/01/23 19:16:14
@@ -1,2 +1,7 @@
+2001-01-20  Iain Holmes  <iain ximian com>
+
+	* gdk-pixbuf/io-png.c (gdk_pixbuf__png_image_stop_load): Destroy the
+	png_info_ptr.
+
 2000-12-08  Federico Mena Quintero  <federico helixcode com>
 
Index: gdk-pixbuf/io-png.c
===================================================================
RCS file: /cvs/gnome/gdk-pixbuf/gdk-pixbuf/io-png.c,v
retrieving revision 1.31
diff -U2 -r1.31 io-png.c
--- gdk-pixbuf/io-png.c	2000/09/06 19:15:40	1.31
+++ gdk-pixbuf/io-png.c	2001/01/23 19:16:15
@@ -348,5 +348,5 @@
         gdk_pixbuf_unref(lc->pixbuf);
         
-        png_destroy_read_struct(&lc->png_read_ptr, NULL, NULL);
+        png_destroy_read_struct(&lc->png_read_ptr, &lc->png_info_ptr, NULL);
         g_free(lc);
 }


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]