Re: gtk+ HEAD compile broken?

[Owen Taylor <otaylor redhat com>]

Mikael Hermansson <tyan linux se> writes:

> gdk-pixbuf/pixops fails with this error:
> 
> gcc -DHAVE_CONFIG_H -I. -I. -I../.. -I../.. -I../../gdk-pixbuf -Wall
> -march=pentium -O3 -ffast-math -Wp,-MD,.deps/pixops.pp -c pixops.c  -fPIC
> -DPIC -o .libs/pixops.lo
> pixops.c:2: glib.h: No such file or directory
> In file included from pixops.c:5:
> pixops.h:4: glib.h: No such file or directory
> In file included from pixops.h:5,
>                  from pixops.c:5:
> ../../gdk-pixbuf/gdk-pixbuf.h:29: glib.h: No such file or directory
> In file included from pixops.h:5,
>                  from pixops.c:5:
> ../../gdk-pixbuf/gdk-pixbuf.h:31: glib-object.h: No such file or directory
> make[3]: *** [pixops.lo] Error 1
> make[3]: Leaving directory `/home/tyan/gnomecvs/gtk+/gdk-pixbuf/pixops'
> make[2]: *** [all-recursive] Error 1
> make[2]: Leaving directory `/home/tyan/gnomecvs/gtk+/gdk-pixbuf'
> make[1]: *** [all-recursive] Error 1
> make[1]: Leaving directory `/home/tyan/gnomecvs/gtk+'
> make: *** [all-recursive-am] Error 2
> 
> ---------------------------------------------------------------------------
> 
> Is below patch ok to submit?

It looks reasonable, though I'm having a little trouble 
telling because your patch was not made with diff -u.

I've committed something similar.

Thanks,
                                        Owen

> Index: gtk+/gdk-pixbuf/pixops/Makefile.am
> ===================================================================
> RCS file: /cvs/gnome/gtk+/gdk-pixbuf/pixops/Makefile.am,v
> retrieving revision 1.10
> diff -r1.10 Makefile.am
> 17a18,26
> > INCLUDES = @STRIP_BEGIN@ \
> > 	-I$(top_srcdir) -I$(top_builddir) 	\
> > 	-I$(top_srcdir)/gdk-pixbuf 		\
> > 	-I$(top_builddir)/gdk-pixbuf 		\
> > 	@INCLUDED_LOADER_DEFINE@ 		\
> > 	@GTK_DEBUG_FLAGS@			\
> > 	@GDK_PIXBUF_DEP_CFLAGS@			\
> > @STRIP_END@
> > 
> 
> _______________________________________________
> gtk-devel-list mailing list
> gtk-devel-list gnome org
p> http://mail.gnome.org/mailman/listinfo/gtk-devel-list