Re: GdkPixmap bugs

[Owen Taylor <otaylor redhat com>]

Ron Steinke <rsteinke w-link net> writes:

> 	There are a couple of bugs in the current CVS:
> 
> 1. gdk_drawable_get_image() doesn't work properly for drawables
> 	where the depth of the visual in the colormap doesn't
> 	match the depth of the drawable. In particular, this
> 	is true for bitmaps created with gdk_pixmap_new()
> 	by passing window = NULL and depth = 1. This is now
> 	on bugzilla as bug #57604.

There isn't supposed to be a "drawable where the depth of the visual in
the colormap doesn't match the depth of the drawable". We probably
should hvae a check and a warning in gdk_drawable_set_colormap()-
for this.

And the colormap handling in gdk_pixmap_new() needs special-casing 
for the case where the depth of the window is not the
same as the depth of the new pixmap. In the case where
depth == 1, we may be able to supply a proper default colormap,
for other depths, we probably should just not set a colormap
on the pixmap at all, since there is no meaningful value. 
 
> 2. At the begining of gdk_pixmap_new(), the parameter "window"
> 	passed to the function is shadowed. This is bizarre,
> 	and I'm suprised the code works at all. Note that
> 	fixing this problem still doesn't fix the previous bug.
> 	I could post this to bugzilla, but somebody should probably
> 	just fix it.

I don't see this - there is no local 'window' variable. 
(Also, posting to bugzilla is a way of making sure something
is fixed, no matter how trivial. In fact, more trivial
things are more likely to get dropped on the flloor.)

                                        Owen