Re: minor fix for GdkPixbuf

[Ramiro Estrugo <ramiro fateware com>]

Havoc Pennington wrote:
> 
> My patch adds gdk_pixbuf_get_from_image() as found in desk guide,
> which means you can write your own code to get the image, avoiding all
> the clipping and race-condition-avoidance code, but still using the
> Hard Bits (the RGB conversion stuff) from GDK in order to convert
> image to pixbuf.
> 
> Owen was suggesting that we actually put the grab in gdk_image_get()
> itself though - if the grab doesn't seem to matter for speed that's
> probably feasible.
> 
> Remember that the grab only happens if you are actually getting from
> an X window; for e.g. nearly all uses of GtkImage, you will actually
> be getting the backing store pixmap, which means you don't need to
> grab. i.e. gdk_image_get() would only grab if
> GDK_IS_WINDOW(src_drawable).
> 
> The only time you actually have to get from an X window is for
> screenshots and maybe for desk guide thumbnailing - applications
> shouldn't ever be doing this assuming they are double-buffering which
> is the normal thing. There's thus no need for grabs to draw menus and
> icons.
> 
> Havoc

This is fine with me.  It sounds like we can indeed lose this hack when
we port to GTK+ 2.0.  Our usage of this feature is basically the same
as the new GtkImage.

thanks

-re