Re: Rationalizing widget default styles



On 26 Jun 2001, Owen Taylor wrote:

>  * It removes:
> 
>     gtk_widget_set_default_style()
>     gtk_widget_push_style()
>     gtk_widget_pop_style()

sounds good.

>  * It makes the canonical way to remove a style set with
>    gtk_widget_set_style (widget, style) -  
>    gtk_widget_set_style (widget, NULL). I believe this is the
>    way of unsetting the style for a widget that would make
>    the most sense to someone familiar with the GTK+ API.

agree.

>  * It makes the functions:
> 
>     gtk_widget_set_rc_style (widget)
>     gtk_widget_restore_default_style (widget)
> 
>    Deprecated aliases for gtk_widget_set_style (widget, NULL);

i suppose the only valid way to actually style-harm ;) a widget then
is gtk_widget_modify_style() right (except for, if you want to create
a new style from scratch)?
shouldn't we just nuke gtk_widget_set_rc_style() and
gtk_widget_restore_default_style() aswell then?

other than that, the diff has too little context, i'll review styles
in gtkwidget.c after you applied.

> 
> Regards,
>                                         Owen
> 
> 

---
ciaoTJ






[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]