Re: Patch to GtkPaned.

[Owen Taylor <otaylor redhat com>]

Comments added to bug #50837:

 - I really don't like the quantum stuff. Trying to get
   it to match up with some meaningful unit in the app
   (a column or whatever) and make that work right 
   for theme changes, etc, seems like an excercise
   in hugely painful fiddling for the app programmer
   for no real benefit for the user.

   I do think that it might be useful to have something 
   like the zoom buttons on swings scrollpanes that could
   be turned. (Or, maybe instead, like the way the 
   Mozilla side bar works.) But that's a different feature.

 - What's up with the random doc comment for gtk_[hv]paned_new()
   GtkPaned is fully documented in the tmpl files. If you
   wanted to move all the function descriptions 
   for Gtk*Paned into the C file I wouldn't object..., but

- Why the logic change:

@@ -577,14 +607,38 @@
        {
          if (paned->child1_resize && !paned->child2_resize)
            paned->child1_size += allocation - paned->last_allocation;
-         else if (!(!paned->child1_resize && paned->child2_resize))
+         else if (paned->child1_resize && paned->child2_resize)
            paned->child1_size = allocation * ((gdouble) paned->child1_size / (paned->last_allocation));
        }

   Note that the original, but not your replacement triggers
   in the case of !paned->child1_resize && !paned->child2_resize.

 [ Perhaps logic here would have been somewhat clearer if I had written, originally

       if (paned->child1_resize && !paned->child2_resize)
          paned->child1_size += allocation - paned->last_allocation;
-      else if (!paned->child1_resize && paned->child2_resize)
          /* Do nothing */;
       else
         paned->child1_size = allocation * ((gdouble) paned->child1_size / (paned->last_allocation));
 ]

 - Why ever is handle_shown virtualized???

 - For symmetry, the test case really should have 4 shown toggles, not
   just two. (Getting to the point where no toggles and a GLE-based
   test plan would work better.)