Re: Problems with expose_event->region patch
- From: Alexander Larsson <alla lysator liu se>
- To: Owen Taylor <otaylor redhat com>
- Cc: <gtk-devel-list gnome org>
- Subject: Re: Problems with expose_event->region patch
- Date: Fri, 9 Mar 2001 14:34:31 +0100 (CET)
I commited this now. Some comments.
On 8 Mar 2001, Owen Taylor wrote:
> > + * @returns: the intersection of @widget and @region
>
> A newly allocated region holding the intersection of @widget
> and @region. The coordinates of the return value are
> relative to widget->window for NO_WINDOW widgets, and
> relative to the widget's allocation for widgets with their
> own window.
>
> Actually, the funky coordinate system for the return value is that way
> because gtk_widget_intersect() was used for ::draw propagation and
> that was the coordinate system that was used for the argument to
> ::draw.
>
> Now that ::draw is gone, I think we should simply make
> gtk_widget_region_intersect() return coordinates relative to
> widget->window. The question then is - should gtk_widget_intersect()
> be changed to match?
You mean relative to parent window (for window widgets)? That is what I
did in the version i comittted.
> It's strange having them be different, and I the number of people who
> actually understand the way the coordinate systems used to work is
> tiny, but then again, there will be one person, somewhere, who will
> have a _HARD_ bug to track down if we change it.
I leave such decisions to you.
/ Alex
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]