Re: [patch] compiling GTK+ w/o X

[Owen Taylor <otaylor redhat com>]

Sven Neumann <sven gimp org> writes:

> Hi,
> 
> Owen Taylor <otaylor redhat com> writes:
> 
> > GDK_ROOT_PARENT() should be provided by all ports, so this
> > patch isn't necessary.
> 
> It is provided by all ports, but is only defined in the port-specific
> headers. The testpixbuf demos won't compile as they are now unless
> you have X11 headers installed since <gdk/x11/gdkx.h> includes them.
> If you don't like using the global variable, there should be a public 
> function gdk_root_parent() defined in gdk.h which is implemented by 
> all backends instead of the GDK_ROOT_PARENT() macro.

The fact that gdk_parent_root happens to be declared in a gdkprivate.h
which is not in a subdir doesn't mean that it is a cross-platform
concept.

If the "root window" as something you can draw upon, and so forth, is
a cross-platform concept, then it needs to be in a public header,
and declared as something like:

 GdkWindow *gdk_window_get_default_root (void);

If not, then your patch doesn't fix anything.

Regards,
                                        Owen