Re: Impact of change to gcompletion.h on building gtk+ on Solaris

["Padraig O'Briain" <Padraig Obriain Sun COM>]

This patch fixes my problem. May I commit?

Padraig


Index: gtkmain.c
===================================================================
RCS file: /cvs/gnome/gtk+/gtk/gtkmain.c,v
retrieving revision 1.159
diff -u -p -r1.159 gtkmain.c
--- gtkmain.c   2001/04/29 03:08:32     1.159
+++ gtkmain.c   2001/05/09 14:56:44
@@ -32,10 +32,14 @@
 #include <libintl.h>
 #endif
 
+
 #include <stdio.h>
 #include <stdlib.h>
 #include <string.h>
 #include <gmodule.h>
+#ifdef G_OS_UNIX
+#include <unistd.h>
+#endif
 #include "gtkdnd.h"
 #include "gtkcompat.h"
 #include "gtkmain.h"


> X-Authentication-Warning: icon.labs.redhat.com: hp set sender to hp redhat com 
using -f
> To: "Padraig O'Briain" <Padraig Obriain sun com>
> Cc: gtk-devel-list gnome org
> Subject: Re: Impact of change to gcompletion.h on building gtk+ on Solaris
> User-Agent: Gnus/5.0807 (Gnus v5.8.7) Emacs/20.7
> MIME-Version: 1.0
> 
> 
> "Padraig O'Briain" <Padraig Obriain Sun COM> writes: 
> > 
> > As far as I can make out this is caused by the removal of the following 
lines 
> > from glib/gcompletion.h:
> > 
> > #ifdef G_OS_UNIX                               
> > #include <unistd.h>                                                            
> > #endif 
> > 
> > 
> > I am building on Solaris. Where is gid_t defined on Linux and how is it 
included 
> > in gtkmain.c?
> > 
> 
> Maybe it isn't, I haven't tried building yet today. ;-)
> 
> The GLib headers aren't supposed to drag in C library headers. 
> The correct fix here would be to put #ifdef G_OS_UNIX #include
> <unistd.h> at the top of gtkmain.c.
> 
> Havoc