Re: Impact of change to gcompletion.h on building gtk+ on Solaris

["Padraig O'Briain" <Padraig Obriain Sun COM>]

Owen,

Your suggestion does not work, for me as I need to include gmodule.h in order 
for G_OS_UNIX to be defined.

Padraig


> Delivered-To: gtk-devel-list gnome org
> To: gtk-devel-list gnome org
> Subject: Re: Impact of change to gcompletion.h on building gtk+ on Solaris
> User-Agent: Gnus/5.0807 (Gnus v5.8.7) Emacs/20.7
> MIME-Version: 1.0
> X-BeenThere: gtk-devel-list gnome org
> X-Loop: gtk-devel-list gnome org
> X-Mailman-Version: 2.0beta5
> List-Id: Development of GTK+ <gtk-devel-list.gnome.org>
> 
> 
> "Padraig O'Briain" <Padraig Obriain Sun COM> writes:
> 
> > This patch fixes my problem. May I commit?
> 
> Go ahead.
> 
> >  #include <stdio.h>
> >  #include <stdlib.h>
> >  #include <string.h>
> >  #include <gmodule.h>
> > +#ifdef G_OS_UNIX
> > +#include <unistd.h>
> > +#endif
> >  #include "gtkdnd.h"
> >  #include "gtkcompat.h"
> >  #include "gtkmain.h"
> 
> Though it's slightly better to keep all the system headers together and before
> other headers, so I'd do:
> 
> #include <stdio.h>
> #include <stdlib.h>
> #include <string.h>
> #ifdef G_OS_UNIX
> #include <unistd.h>
> #endif
> 
> #include <gmodule.h>
> 
> #include "gtkdnd.h"
> #include "gtkcompat.h"
> #include "gtkmain.h"
> 
> Regards,
>                                         Owen
> 
> _______________________________________________
> gtk-devel-list mailing list
> gtk-devel-list gnome org
> http://mail.gnome.org/mailman/listinfo/gtk-devel-list