Re: #52434 - Lock accelerators by default

[Owen Taylor <otaylor redhat com>]

Tim Janik <timj gtk org> writes:

> On 20 May 2001, Havoc Pennington wrote:
> 
> > 
> > Hi,
> > 
> > Going to check in this change soon unless there are complaints, it's
> > been around for a month or so.
> > 
> > Havoc
> > 
> > Index: ChangeLog
> > ===================================================================
> > RCS file: /cvs/gnome/gtk+/ChangeLog,v
> > retrieving revision 1.1973
> > diff -u -u -r1.1973 ChangeLog
> > --- ChangeLog	2001/05/20 22:48:37	1.1973
> > +++ ChangeLog	2001/05/20 22:57:17
> > @@ -1,3 +1,14 @@
> > +2001-05-07  Havoc Pennington  <hp redhat com>
> > +
> > +	* gtk/gtkwidget.c, gtk/gtkprivate.h, gtk/gtkitemfactory.c: Apply
> > +	Owen's patch for an ACCELS_LOCKED private widget flag, setting
> > +	that flag by default, and unsetting it in GtkItemFactory
> > +	(gtk_widget_class_init): Install global setting for whether 
> > +	to allow accel changing (i.e. if the flag is FALSE, we pretend
> > +	the locked flag is always set)
> > +	(gtk_widget_accelerators_locked): return TRUE if accelerators
> > +	aren't editable according to the user setting
> > +
> 
> i'm not sure we actually need that.
> once we have:
> 1) support accel locking globally throguh rc-files
> 2) runtime accel changes on menus honouring mnemonics in conflict resolution
> 3) default locking of menuitem accelerators that got no accel group
>    through item factory (or equivalent mechanism)
> 4) nuked the global default accel group (NULL)

I don't really understand. What are you saying we don't need?

1) This patch adds a GtkSetting for this
2) Doesn't seem related.
3) How do you find out if a widget has an accelerator or not? (Other than
 checking to see if accelerators are locked for the widget or not.)
4) Doesn't really seem related.

Regads,
                                        Owen